eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Include empty header values when joining duplicated headers

Browse Source 
Fixes a regression from commit:
f675cfe90f

It is not sufficient to only check if the builder is empty, as we will
then drop empty header values (when the first found value is empty).

This is tested in WPT by /cors/origin.htm, but that requires an HTTP
server.
This commit is contained in:
Timothy Flynn
2025-11-26 20:05:36 -05:00
committed by Tim Flynn
parent 00070455fd
commit cbfae97101
Notes: github-actions[bot] 2025-11-27 02:23:46 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/cbfae97101e
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6949
3 changed files with 28 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Libraries/LibWeb/Fetch/Infrastructure/HTTP/Headers.cpp
View File

@@ -86,14 +86,17 @@ Optional<ByteString> HeaderList::get(StringView name) const
// 2. Return the values of all headers in list whose name is a byte-case-insensitive match for name, separated from
// each other by 0x2C 0x20, in order.
StringBuilder builder;
bool first = true;
for (auto const& header : *this) {
if (!header.name.equals_ignoring_ascii_case(name))
continue;
if (!builder.is_empty())
if (!first)
builder.append(", "sv);
builder.append(header.value);
first = false;
}
return builder.to_byte_string();