eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-02 12:32:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS+LibUnicode: Do not generate the PluralCategory enum

Browse Source 
The PluralCategory enum is currently generated for plural rules. Instead
of generating it, this moves the enum to the public LibUnicode header.
While it was nice to auto-discover these values, they are well defined
by TR-35, and we will need their values from within the number format
code generator (which can't rely on the plural rules generator having
run yet). Further, number format will require additional values in the
enum that plural rules doesn't know about.
This commit is contained in:
Timothy Flynn
2022-07-08 07:52:54 -04:00
committed by Linus Groh
parent 9369610bf4
commit cc5c707649
Notes: sideshowbarker 2024-07-17 09:36:17 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/cc5c707649
Pull-request: https://github.com/SerenityOS/serenity/pull/14516
Reviewed-by: https://github.com/linusg ✅
5 changed files with 50 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeRelativeTimeFormat.cpp
View File

@@ -203,8 +203,8 @@ static ErrorOr<void> generate_unicode_locale_implementation(Core::Stream::Buffer
#include <AK/StringView.h>
#include <AK/Vector.h>
#include <LibUnicode/Locale.h>
#include <LibUnicode/PluralRules.h>
#include <LibUnicode/RelativeTimeFormat.h>
#include <LibUnicode/UnicodePluralRules.h>
#include <LibUnicode/UnicodeRelativeTimeFormat.h>
namespace Unicode {