eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-02 20:42:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Add a function to ensure calls are made within the same second

Browse Source 
Before these tests could be flaky if they happened to be called around
the edge of a second. Now we try up to 5 times to execute the tests
while staying within the same second.
This commit is contained in:
davidot
2022-12-02 17:25:40 +01:00
committed by Linus Groh
parent 146d45a652
commit cf0d30add6
Notes: sideshowbarker 2024-07-17 03:45:41 +09:00 
Author: https://github.com/davidot
Commit: https://github.com/SerenityOS/serenity/commit/cf0d30add6
Pull-request: https://github.com/SerenityOS/serenity/pull/16287
Reviewed-by: https://github.com/linusg ✅
3 changed files with 41 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Userland/Libraries/LibJS/Tests/builtins/Temporal/Now/Now.plainDateTimeISO.js
View File

@@ -35,12 +35,12 @@ describe("correct behavior", () => {
},
};
const plainDateTime = Temporal.Now.plainDateTimeISO("UTC");
const plainDateTimeWithOffset = Temporal.Now.plainDateTimeISO(timeZone);
const [plainDateTime, plainDateTimeWithOffset] = withinSameSecond(() => {
return [Temporal.Now.plainDateTimeISO("UTC"), Temporal.Now.plainDateTimeISO(timeZone)];
});
if (plainDateTime.year !== plainDateTimeWithOffset.year) return;
// Let's hope the duration between the above two lines is less than a second :^)
const differenceSeconds =
plainDateTimeToEpochSeconds(plainDateTimeWithOffset) -
plainDateTimeToEpochSeconds(plainDateTime);
@@ -55,12 +55,12 @@ describe("correct behavior", () => {
},
};
const plainDateTime = Temporal.Now.plainDateTimeISO("UTC");
const plainDateTimeWithOffset = Temporal.Now.plainDateTimeISO(timeZone);
const [plainDateTime, plainDateTimeWithOffset] = withinSameSecond(() => {
return [Temporal.Now.plainDateTimeISO("UTC"), Temporal.Now.plainDateTimeISO(timeZone)];
});
if (plainDateTime.year !== plainDateTimeWithOffset.year) return;
// Let's hope the duration between the above two lines is less than a second :^)
const differenceSeconds =
plainDateTimeToEpochSeconds(plainDateTimeWithOffset) -
plainDateTimeToEpochSeconds(plainDateTime);