eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/Node: Rename Node::can_contain_boxes_with_position_absolute()

Browse Source 
This method matches the spec concept of "establishing an absolute
positioning containing block", so let's use that name.
This commit is contained in:
Sam Atkins
2025-12-16 11:57:17 +00:00
parent cef2591007
commit cf2520d6a4
Notes: github-actions[bot] 2026-01-06 15:56:44 +00:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/LadybirdBrowser/ladybird/commit/cf2520d6a4c
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7158
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Libraries/LibWeb/Layout/Node.cpp
View File

@@ -75,7 +75,8 @@ bool Node::is_out_of_flow(FormattingContext const& formatting_context) const
return false;
}
bool Node::can_contain_boxes_with_position_absolute() const
// https://drafts.csswg.org/css-position-3/#absolute-positioning-containing-block
bool Node::establishes_an_absolute_positioning_containing_block() const
{
if (!is<Box>(*this))
return false;
@@ -149,7 +150,7 @@ void Node::recompute_containing_block(Badge<DOM::Document>)
// https://drafts.csswg.org/css-position-3/#absolute-cb
if (position == CSS::Positioning::Absolute) {
auto* ancestor = parent();
while (ancestor && !ancestor->can_contain_boxes_with_position_absolute())
while (ancestor && !ancestor->establishes_an_absolute_positioning_containing_block())
ancestor = ancestor->parent();
m_containing_block = static_cast<Box*>(ancestor);
return;