eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 18:17:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Use href content attribute value in follow_the_hyperlink()

Browse Source 
Previously we were using the IDL attribute value, which didn't follow
the specification.
This commit is contained in:
Tim Ledbetter
2026-01-12 18:46:35 +00:00
committed by Jelle Raaijmakers
parent 0448731059
commit cf3a49cda6
Notes: github-actions[bot] 2026-01-13 09:07:08 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/cf3a49cda65
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7445
Reviewed-by: https://github.com/gmta ✅
Reviewed-by: https://github.com/shannonbooth ✅
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLHyperlinkElementUtils.cpp
View File

@@ -496,7 +496,7 @@ void HTMLHyperlinkElementUtils::follow_the_hyperlink(Optional<String> hyperlink_
target_attribute_value = hyperlink_element_utils_get_an_elements_target();
// 4. Let urlRecord be the result of encoding-parsing a URL given subject's href attribute value, relative to subject's node document.
auto url_record = element.document().encoding_parse_url(href());
auto url_record = element.document().encoding_parse_url(element.get_attribute_value(HTML::AttributeNames::href));
// 5. If urlRecord is failure, then return.
if (!url_record.has_value())