eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 17:55:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Map logical aliases at cascade time

Browse Source 
Previously we would incorrectly map these in
`CSSStyleProperties::convert_declarations_to_specified_order`, aside
from being too early (as it meant we didn't maintain them as distinct
from their physical counterparts in CSSStyleProperties), this meant
that we didn't yet have the required context to map them correctly.

We now map them as part of the cascade process. To compute the mapping
context we do a cascade without mapping, and extract the relevant
properties (writing-direction and direction).
This commit is contained in:
Callum Law
2025-06-18 17:45:26 +12:00
committed by Sam Atkins
parent 4e87f85458
commit cfc8d3031b
Notes: github-actions[bot] 2025-06-23 14:20:40 +00:00 
Author: https://github.com/Calme1709
Commit: https://github.com/LadybirdBrowser/ladybird/commit/cfc8d3031b8
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5138
Reviewed-by: https://github.com/AtkinsSJ ✅
14 changed files with 848 additions and 141 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Tests/LibWeb/Text/expected/wpt-import/css/cssom/cssom-getPropertyValue-common-checks.txt
View File

@@ -2,13 +2,12 @@ Harness status: OK
Found 11 tests
7 Pass
4 Fail
Fail All properties can serialize 'initial'
11 Pass
Pass All properties can serialize 'initial'
Pass All properties (except 'all') can serialize their initial value (computed)
Fail All properties (except 'all') can serialize their initial value (specified)
Fail All shorthands can serialize their longhands set to 'initial'
Fail All shorthands (except 'all') can serialize their longhands set to their initial value
Pass All properties (except 'all') can serialize their initial value (specified)
Pass All shorthands can serialize their longhands set to 'initial'
Pass All shorthands (except 'all') can serialize their longhands set to their initial value
Pass All aliases can serialize target property set to 'initial'
Pass All aliases can serialize target property set to its initial value
Pass Can't serialize shorthand when longhands are set to different css-wide keywords