eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-30 19:47:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Implement “suffering from a step mismatch” constraint validation

Browse Source
This commit is contained in:
sideshowbarker
2025-03-04 13:25:15 +09:00
committed by Tim Ledbetter
parent 12f5e9c5f8
commit d14856e3c5
Notes: github-actions[bot] 2025-03-04 08:22:55 +00:00 
Author: https://github.com/sideshowbarker
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d14856e3c54
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3792
Reviewed-by: https://github.com/tcl3 ✅
2 changed files with 34 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
Libraries/LibWeb/HTML/HTMLInputElement.cpp
View File

@@ -3098,10 +3098,20 @@ bool HTMLInputElement::suffering_from_an_overflow() const
// https://html.spec.whatwg.org/multipage/input.html#the-step-attribute%3Asuffering-from-a-step-mismatch
bool HTMLInputElement::suffering_from_a_step_mismatch() const
{
// When the element has an allowed value step, and the result of applying the algorithm to convert a string to a number to the string given by the element's
// value is a number, and that number subtracted from the step base is not an integral multiple of the allowed value step, the element is suffering from a step mismatch.
// FIXME: Implement this.
return false;
// When the element has an allowed value step,
auto maybe_allowed_value_step = allowed_value_step();
if (!maybe_allowed_value_step.has_value())
return false;
double allowed_value_step = *maybe_allowed_value_step;
// and the result of applying the algorithm to convert a string to a number to the string given by the element's
// value is a number,
auto maybe_number = convert_string_to_number(value());
if (!maybe_number.has_value())
return false;
double number = maybe_number.value();
// and that number subtracted from the step base is not an integral multiple of the allowed value step, the element
// is suffering from a step mismatch.
return fmod(step_base() - number, allowed_value_step) != 0;
}
// https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#suffering-from-bad-input