eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Protect animation frame callbacks from GC while they execute

Browse Source 
Stealing the callbacks from the AnimationFrameCallbackDriver made them
no longer safe from GC. Continue to store them on the class until we
have finished their execution.
This commit is contained in:
Timothy Flynn
2024-10-31 10:05:44 -04:00
committed by Andreas Kling
parent f6991a2955
commit d188aaf288
Notes: github-actions[bot] 2024-10-31 14:38:43 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d188aaf2889
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2083
Reviewed-by: https://github.com/awesomekling
Reviewed-by: https://github.com/shannonbooth
4 changed files with 23 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Userland/Libraries/LibWeb/HTML/AnimationFrameCallbackDriver.h
View File

@@ -34,6 +34,7 @@ private:
WebIDL::UnsignedLong m_animation_frame_callback_identifier { 0 };
OrderedHashMap<WebIDL::UnsignedLong, Callback> m_callbacks;
OrderedHashMap<WebIDL::UnsignedLong, Callback> m_executing_callbacks;
};
}