eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-28 10:37:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Compare Screenshot tests directly against expected PNGs

Browse Source 
Instead of rendering a reference HTML page that wraps an <img> tag
pointing to a PNG, Screenshot tests now load the expected PNG directly
from disk and compare it against the rendered screenshot. This
eliminates the indirection of loading and rendering a second page just
to display a static image.

This also means --rebaseline now works for Screenshot tests, generating
the expected PNG automatically instead of requiring manual screenshot
capture and placement.

Changes:
- Add TestMode::Screenshot with its own collector and runner
- Move PNGs from Screenshot/images/ to Screenshot/expected/ with
  normalized names matching input filenames
- Remove all 92 reference HTML wrapper files and the images/
  directory
- Remove <link rel="match"> from all 94 Screenshot input HTML
  files
- Update add_libweb_test.py Screenshot boilerplate accordingly
- Add Screenshot mode to results viewer image comparison tabs
This commit is contained in:
Aliaksandr Kalenik
2026-02-24 08:17:16 +01:00
committed by Jelle Raaijmakers
parent 86bc379119
commit d2528dd5ce
Notes: github-actions[bot] 2026-02-24 08:56:11 +00:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d2528dd5ce8
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8122
Reviewed-by: https://github.com/gmta ✅
277 changed files with 176 additions and 1143 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Tests/LibWeb/Screenshot/input/svg-gradient-componentTransfer.html
View File

@@ -1,5 +1,4 @@
<!DOCTYPE html>
<link rel="match" href="../expected/svg-gradient-componentTransfer-ref.html" />
<style>
svg {
margin: 5px;