eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 09:45:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Ensure all passed arguments are used when parsing math functions

Browse Source 
This disallows things such as `log(1, foobar)` where we would previously
just skip over `foobar` and parse this as `log(1)`
This commit is contained in:
Callum Law
2025-10-22 17:27:08 +13:00
committed by Sam Atkins
parent 1977a976da
commit d32f99b16f
Notes: github-actions[bot] 2025-10-23 08:35:51 +00:00 
Author: https://github.com/Calme1709
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d32f99b16f2
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6544
Reviewed-by: https://github.com/AtkinsSJ ✅
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSMathFunctions.cpp
View File

@@ -417,6 +417,10 @@ RefPtr<CalculationNode const> Parser::parse_math_function(Function const& functi
parameter_index++;
});
function_generator.append(R"~~~(
if (argument_index < arguments.size())
return nullptr;
)~~~");
// Generate the call to the constructor
function_generator.append(" return @name:titlecase@CalculationNode::create("sv);
parameter_index = 0;