eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Shrink ExecutionContext by replacing ScriptOrModule with Cell*

Browse Source 
Replace the 16-byte Variant<Empty, GC::Ref<Script>, GC::Ref<Module>>
with a simple 8-byte GC::Ptr<Cell> that points to either a Script or
Module (or is null for Empty).

A helper function script_or_module_from_cell() converts back to the
full ScriptOrModule variant when needed (e.g. in
VM::get_active_script_or_module).
This commit is contained in:
Andreas Kling
2026-03-08 13:29:49 +01:00
committed by Andreas Kling
parent c8ad07dece
commit d3495c62a7
Notes: github-actions[bot] 2026-03-11 12:35:02 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d3495c62a72
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8360
Reviewed-by: https://github.com/shannonbooth
16 changed files with 60 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/DOM/EventTarget.cpp
View File

@@ -518,7 +518,7 @@ WebIDL::CallbackType* EventTarget::get_current_value_of_event_handler(FlyString
vm.pop_execution_context();
// 11. Set function.[[ScriptOrModule]] to null.
function->set_script_or_module({});
function->set_script_or_module(nullptr);
// 12. Set eventHandler's value to the result of creating a Web IDL EventHandler callback function object whose object reference is function and whose callback context is settings object.
// FIXME: Update this comment once the ShadowRealm proposal is merged to pass realm.