eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 17:55:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibCore+Everywhere: Make Core::Stream read_line() return StringView

Browse Source 
Similar reasoning to making Core::Stream::read() return Bytes, except
that every user of read_line() creates a StringView from the result, so
let's just return one right away.
This commit is contained in:
Sam Atkins
2022-04-15 14:52:33 +01:00
committed by Tim Flynn
parent c4134e9794
commit d564cf1e89
Notes: sideshowbarker 2024-07-17 11:46:28 +09:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/SerenityOS/serenity/commit/d564cf1e89
Pull-request: https://github.com/SerenityOS/serenity/pull/13694
Reviewed-by: https://github.com/trflynn89
9 changed files with 40 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibWebSocket/Impl/WebSocketImpl.cpp
View File

@@ -63,8 +63,8 @@ ErrorOr<ByteBuffer> WebSocketImpl::read(int max_size)
ErrorOr<String> WebSocketImpl::read_line(size_t size)
{
auto buffer = TRY(ByteBuffer::create_uninitialized(size));
auto nread = TRY(m_socket->read_line(buffer));
return String::copy(buffer.span().slice(0, nread));
auto line = TRY(m_socket->read_line(buffer));
return line.to_string();
}
}