eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-02 04:27:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Limit usage of getElementById() cache to connected roots

Browse Source 
Fixes bug when we always return null from getElementById() on
unconnected roots because id to element cache is only maintained for
connected roots.

Fixes broken Perf-Dashboard suite in Speedometer 3.
This commit is contained in:
Aliaksandr Kalenik
2025-04-06 02:28:18 +02:00
committed by Alexander Kalenik
parent 3c2a2bb39f
commit d5edd62e57
Notes: github-actions[bot] 2025-04-06 02:15:27 +00:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d5edd62e579
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4247
Reviewed-by: https://github.com/awesomekling ✅
3 changed files with 24 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
Tests/LibWeb/Text/input/DOM/getElementById-on-unconnected-shadow-tree.html Normal file
View File

@@ -0,0 +1,13 @@
<!DOCTYPE html>
<body></body>
<script src="../include.js"></script>
<script>
test(() => {
let host = document.createElement("div");
let shadow = host.attachShadow({ mode: "open" });
shadow.innerHTML = `<p id="foo">Hello</p><span id="bar">World</span>`;
let foo = shadow.getElementById("foo");
let bar = shadow.getElementById("bar");
println(foo.textContent + bar.textContent);
});
</script>