eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Clear the playback manager when forgetting media tracks

Browse Source 
This fixes a crash that would occasionally happen in media-load-during-
track-setup.html, where the media element would add new tracks to the
AudioTrackList or VideoTrackList after the src attribute changed and
caused the element to clear those lists.

In order to make this safe, the on_unsupported_format_error needs to
queue a task to invoke the failure callback which eventually clears
the playback manager, or ~PlaybackManager() will try to destroy the
enclosing lambda.
This commit is contained in:
Zaggy1024
2026-02-25 14:20:56 -06:00
committed by Gregory Bertilson
parent 57e36ce77c
commit d6530d070f
Notes: github-actions[bot] 2026-02-27 04:04:20 +00:00 
Author: https://github.com/Zaggy1024
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d6530d070f9
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8179
Reviewed-by: https://github.com/shannonbooth
Reviewed-by: https://github.com/trflynn89
1 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View File

@@ -1524,12 +1524,21 @@ void HTMLMediaElement::set_up_playback_manager(NonnullRefPtr<FetchData> const& f
});
// -> If the media data can be fetched but is found by inspection to be in an unsupported format, or can otherwise not be rendered at all
m_playback_manager->on_unsupported_format_error = GC::weak_callback(*this, [fetch_data](auto& self, auto&& error) {
// 1. The user agent should cancel the fetching process.
self.cancel_the_fetching_process();
m_playback_manager->on_unsupported_format_error = GC::weak_callback(*this, [fetch_data = fetch_data](auto& self, Media::DecoderError&& error) mutable {
// NB: Queue a task for this so that we don't destroy the PlaybackManager within one of its callbacks when we
// call forget_media_resource_specific_tracks().
self.queue_a_media_element_task([self = GC::Weak(self), fetch_data = fetch_data, error = move(error)] {
if (!self)
return;
if (self->m_error)
return;
// 2. Abort this subalgorithm, returning to the resource selection algorithm.
fetch_data->failure_callback(MUST(String::from_utf8(error.description())));
// 1. The user agent should cancel the fetching process.
self->cancel_the_fetching_process();
// 2. Abort this subalgorithm, returning to the resource selection algorithm.
fetch_data->failure_callback(MUST(String::from_utf8(error.description())));
});
});
// -> If the media data is corrupted
@@ -1636,6 +1645,7 @@ void HTMLMediaElement::forget_media_resource_specific_tracks()
// this; the error and emptied events, fired by the algorithms that invoke this one, can be used instead.
m_audio_tracks->remove_all_tracks({});
m_video_tracks->remove_all_tracks({});
m_playback_manager.clear();
}
// https://html.spec.whatwg.org/multipage/media.html#ready-states:media-element-3