eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Make Animation's owning element an AbstractElement

Browse Source 
From the spec:
> The owning element of a transition refers to the element or
  pseudo-element to which the transition-property property was applied
  that generated the animation.

https://drafts.csswg.org/css-transitions-2/#owning-element

Previously we only stored the element.
This commit is contained in:
Sam Atkins
2025-12-02 11:17:41 +00:00
committed by Andreas Kling
parent b61c857c64
commit d717dd64b3
Notes: github-actions[bot] 2025-12-03 12:31:08 +00:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d717dd64b3d
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6998
6 changed files with 22 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Libraries/LibWeb/Animations/Animation.cpp
View File

@@ -279,7 +279,7 @@ WebIDL::ExceptionOr<void> Animation::set_playback_rate(double new_playback_rate)
// https://www.w3.org/TR/web-animations-1/#animation-play-state
Bindings::AnimationPlayState Animation::play_state_for_bindings() const
{
if (m_owning_element)
if (m_owning_element.has_value())
m_owning_element->document().update_style();
return play_state();
@@ -338,7 +338,7 @@ bool Animation::is_replaceable() const
// - The existence of the animation is not prescribed by markup. That is, it is not a CSS animation with an owning
// element, nor a CSS transition with an owning element.
if ((is_css_animation() || is_css_transition()) && owning_element())
if ((is_css_animation() || is_css_transition()) && owning_element().has_value())
return false;
// - The animation's play state is finished.
@@ -1368,7 +1368,8 @@ void Animation::visit_edges(Cell::Visitor& visitor)
visitor.visit(m_timeline);
visitor.visit(m_current_ready_promise);
visitor.visit(m_current_finished_promise);
visitor.visit(m_owning_element);
if (m_owning_element.has_value())
m_owning_element->visit(visitor);
}
}