eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 17:55:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Make more use of Value::is and Value::as_if in JS runtime

Browse Source
This commit is contained in:
Timothy Flynn
2026-02-27 10:05:55 -05:00
committed by Shannon Booth
parent cadba4c0e7
commit d7e828a366
Notes: github-actions[bot] 2026-02-27 16:20:55 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d7e828a3661
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8208
Reviewed-by: https://github.com/shannonbooth ✅
31 changed files with 109 additions and 145 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
Libraries/LibJS/Runtime/ArrayBufferConstructor.cpp
View File

@@ -60,7 +60,7 @@ ThrowCompletionOr<GC::Ref<Object>> ArrayBufferConstructor::construct(FunctionObj
if (byte_length_or_error.is_error()) {
auto error = byte_length_or_error.release_error();
if (error.value().is_object() && is<RangeError>(error.value().as_object())) {
if (error.value().is<RangeError>()) {
// Re-throw more specific RangeError
return vm.throw_completion<RangeError>(ErrorType::InvalidLength, "array buffer");
}
@@ -81,16 +81,17 @@ JS_DEFINE_NATIVE_FUNCTION(ArrayBufferConstructor::is_view)
// 1. If arg is not an Object, return false.
if (!arg.is_object())
return Value(false);
return false;
auto const& object = arg.as_object();
// 2. If arg has a [[ViewedArrayBuffer]] internal slot, return true.
if (arg.as_object().is_typed_array())
return Value(true);
if (is<DataView>(arg.as_object()))
return Value(true);
if (object.is_typed_array())
return true;
if (is<DataView>(object))
return true;
// 3. Return false.
return Value(false);
return false;
}
// 25.1.5.3 get ArrayBuffer [ @@species ], https://tc39.es/ecma262/#sec-get-arraybuffer-@@species