eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-30 19:47:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Fix hit testing for text inside stacking context roots

Browse Source 
When an element creates a stacking context (e.g. via position: relative
with z-index), its text fragments were not being hit tested. This was
because PaintableBox::hit_test() returns early when it has a stacking
context, and StackingContext::hit_test() only iterated child paintables,
not the stacking context root's own fragments.

Fix this by extracting fragment hit testing into a new method
hit_test_fragments() on PaintableWithLines, and calling it from
StackingContext::hit_test() when the stacking context root is a
PaintableWithLines.
This commit is contained in:
Andreas Kling
2026-01-24 23:07:31 +01:00
committed by Alexander Kalenik
parent afdde488c3
commit d91c646788
Notes: github-actions[bot] 2026-02-06 11:07:59 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d91c6467881
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7613
Reviewed-by: https://github.com/kalenikaliaksandr ✅
5 changed files with 73 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Tests/LibWeb/Text/expected/hit_testing/stacking-context-with-inline-content.txt Normal file
View File

@@ -0,0 +1,4 @@
node: #text
text: LMAO
indexInNode: 1