eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-02 20:42:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Require existing Selection for .execCommand("selectAll")

Browse Source 
Disable the command if no selection is available. This is a spec bug:

https://github.com/w3c/editing/issues/475

Fixes #3325
This commit is contained in:
Jelle Raaijmakers
2025-01-20 23:56:55 +01:00
committed by Tim Ledbetter
parent 96e074b38f
commit d967f56936
Notes: github-actions[bot] 2025-01-21 02:28:49 +00:00 
Author: https://github.com/gmta
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d967f56936e
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3328
Reviewed-by: https://github.com/tcl3 ✅
3 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Tests/LibWeb/Text/input/Editing/execCommand-selectAll.html
View File

@@ -33,5 +33,17 @@
// Perform selectAll
document.execCommand('selectAll');
reportSelection();
// Report whether command is enabled and make sure it does not crash
const documents = [
document,
new Document(),
document.implementation.createHTMLDocument(),
];
for (const doc of documents) {
println(doc.queryCommandEnabled('selectAll'));
doc.execCommand('selectAll');
}
println('Did not crash!');
});
</script>