eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibIPC+LibWeb+LibWebView: Remove clone_from_transport() API

Browse Source 
Replace clone_from_transport() (which dup()s the FD) with
from_transport() (which releases the FD) in the WebWorkerClient
call site. The UI process never uses the WebWorkerClient connection
after spawning — it only passes the transport to WebContent — so
releasing instead of cloning is safe and simpler.

This removes clone_from_transport() from TransportHandle, and
clone_for_transfer() from TransportSocket/TransportSocketWindows,
as they no longer have any callers.
This commit is contained in:
Aliaksandr Kalenik
2026-03-13 14:54:06 +01:00
committed by Jelle Raaijmakers
parent 269d5f739b
commit db9652643a
Notes: github-actions[bot] 2026-03-13 14:35:25 +00:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/LadybirdBrowser/ladybird/commit/db9652643a4
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8398
Reviewed-by: https://github.com/gmta ✅
9 changed files with 2 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Libraries/LibWebView/WebContentClient.cpp
View File

@@ -791,7 +791,8 @@ Messages::WebContentClient::RequestWorkerAgentResponse WebContentClient::request
auto request_server_handle = MUST(connect_new_request_server_client());
auto image_decoder_handle = MUST(connect_new_image_decoder_client());
auto worker_client = MUST(WebView::launch_web_worker_process(worker_type));
return { worker_client->clone_transport(), move(request_server_handle), move(image_decoder_handle) };
auto worker_handle = MUST(IPC::TransportHandle::from_transport(worker_client->transport()));
return { move(worker_handle), move(request_server_handle), move(image_decoder_handle) };
}
return { IPC::TransportHandle {}, IPC::TransportHandle {}, IPC::TransportHandle {} };