eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Make Completion.[[Value]] non-optional

Browse Source 
Instead, just use js_undefined() whenever the [[Value]] field is unused.
This avoids a whole bunch of presence checks.
This commit is contained in:
Andreas Kling
2025-04-04 18:11:45 +02:00
committed by Andreas Kling
parent c0600c4353
commit de424d6879
Notes: github-actions[bot] 2025-04-05 09:21:48 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/de424d68796
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4232
65 changed files with 225 additions and 250 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibTest/JavaScriptTestRunner.h
View File

@@ -431,7 +431,7 @@ inline JSFileResult TestRunner::run_file_test(ByteString const& test_path)
suite.most_severe_test_result = Result::Crashed;
Test::Case test_case { "<top-level>"_string, Test::Result::Fail, {}, 0 };
auto error = top_level_result.release_error().release_value().release_value();
auto error = top_level_result.release_error().release_value();
if (error.is_object()) {
StringBuilder detail_builder;