eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 03:57:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Kernel: Lock the inode before writing in SharedInodeVMObject::sync

Browse Source 
We ensure that when we call SharedInodeVMObject::sync we lock the inode
lock before calling Inode virtual write_bytes method directly to avoid
assertion on the unlocked inode lock, as it was regressed recently. This
is not a complete fix as the need to lock from each path before calling
the write_bytes method should be avoided because it can lead to
hard-to-find bugs, and this commit only fixes the problem temporarily.
This commit is contained in:
Mike Akers
2022-08-12 09:48:59 -04:00
committed by Andreas Kling
parent 0b9d83fe0d
commit de980de0e4
Notes: sideshowbarker 2024-07-19 17:04:23 +09:00 
Author: https://github.com/mikeakers
Commit: https://github.com/SerenityOS/serenity/commit/de980de0e48
Pull-request: https://github.com/SerenityOS/serenity/pull/14836
Reviewed-by: https://github.com/supercomputer7 ✅
2 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Kernel/Memory/SharedInodeVMObject.cpp
View File

@@ -53,6 +53,7 @@ ErrorOr<void> SharedInodeVMObject::sync(off_t offset_in_pages, size_t pages)
u8 page_buffer[PAGE_SIZE];
MM.copy_physical_page(*physical_page, page_buffer);
MutexLocker locker(m_inode->m_inode_lock);
TRY(m_inode->write_bytes(page_index * PAGE_SIZE, PAGE_SIZE, UserOrKernelBuffer::for_kernel_buffer(page_buffer), nullptr));
}