eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibMedia+LibWeb: Prefer MatroskaDemuxer for media playback

Browse Source 
MatroskaDemuxer supports multiple streams already, and gives us a bit
more control over seeking.
This commit is contained in:
Zaggy1024
2025-09-27 15:11:06 -05:00
committed by Jelle Raaijmakers
parent 0ff330c906
commit dfe59b8a4f
Notes: github-actions[bot] 2025-10-28 00:35:18 +00:00 
Author: https://github.com/Zaggy1024
Commit: https://github.com/LadybirdBrowser/ladybird/commit/dfe59b8a4f2
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6410
Reviewed-by: https://github.com/R-Goc
Reviewed-by: https://github.com/gmta ✅
3 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View File

@@ -1173,7 +1173,7 @@ WebIDL::ExceptionOr<void> HTMLMediaElement::process_media_data(Function<void(Str
{
auto& realm = this->realm();
auto playback_manager_result = Media::PlaybackManager::try_create(make<FixedMemoryStream>(m_media_data.bytes()));
auto playback_manager_result = Media::PlaybackManager::try_create(m_media_data.bytes());
// -> If the media data cannot be fetched at all, due to network errors, causing the user agent to give up trying to fetch the resource
// -> If the media data can be fetched but is found by inspection to be in an unsupported format, or can otherwise not be rendered at all