eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

WebDriver: Stop using the ancient Core::EventReceiver parent/child API

Browse Source 
Before this change, clients were kept alive by making them children of
the TCPServer object. This ownership model is going away (and this was
the only remaining use of it!) so let's just put the clients in a hash
table instead.
This commit is contained in:
Andreas Kling
2025-08-10 16:34:51 +02:00
committed by Andreas Kling
parent 045eaa1576
commit dfe776b722
Notes: github-actions[bot] 2025-08-11 14:57:31 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/dfe776b7225
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5817
Reviewed-by: https://github.com/gmta ✅
5 changed files with 24 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/LibWeb/WebDriver/Client.h
View File

@@ -116,8 +116,10 @@ public:
// 18. Print, https://w3c.github.io/webdriver/#print
virtual Response print_page(Parameters parameters, JsonValue payload) = 0;
Function<void()> on_death;
protected:
Client(NonnullOwnPtr<Core::BufferedTCPSocket>, Core::EventReceiver* parent);
explicit Client(NonnullOwnPtr<Core::BufferedTCPSocket>);
private:
using WrappedError = Variant<AK::Error, HTTP::HttpRequest::ParseError, WebDriver::Error>;