eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-03 21:12:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Mark compilation-unit-only functions as static

Browse Source 
This enables a nice warning in case a function becomes dead code. Also, in the
case of {Event,Node}WrapperFactory.cpp, the corresponding header was forgotten.
This would cause an issue later when we enable -Wmissing-declarations.

Is my clang-format misconfigured? Why is the diff for NodeWrapperFactory.cpp
so large?
This commit is contained in:
Ben Wiederhake
2020-08-11 00:07:16 +02:00
committed by Andreas Kling
parent 3ec7b8b33c
commit e050f21f36
Notes: sideshowbarker 2024-07-19 03:42:33 +09:00 
Author: https://github.com/BenWiederhake
Commit: https://github.com/SerenityOS/serenity/commit/e050f21f361
Pull-request: https://github.com/SerenityOS/serenity/pull/3096
Reviewed-by: https://github.com/awesomekling
Reviewed-by: https://github.com/stelar7
5 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp
View File

@@ -116,7 +116,7 @@ struct Interface {
String fully_qualified_name;
};
OwnPtr<Interface> parse_interface(const StringView& input)
static OwnPtr<Interface> parse_interface(const StringView& input)
{
auto interface = make<Interface>();
@@ -339,7 +339,6 @@ int main(int argc, char** argv)
interface->fully_qualified_name = interface->name;
}
#if 0
dbg() << "Attributes:";
for (auto& attribute : interface->attributes) {