eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 10:07:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Always store ComputedProperties, even if no invalidations

Browse Source 
Before this change, we'd skip storing the new ComputedProperties in
Element::recompute_style() if there was no invalidation needed.

This caused us to lose the information about which properties are
inherited and/or important (which is also carried by ComputedProperties,
but doesn't affect invalidation).

Consequently, we'd then fail to recompute inherited styles, since that
mechanism depends on this data.

The fix is simply to always store the new ComputedProperties.
This commit is contained in:
Andreas Kling
2025-04-12 22:45:25 +02:00
committed by Andreas Kling
parent 9ba76ea25a
commit e068ff5a5d
Notes: github-actions[bot] 2025-04-12 22:44:44 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/e068ff5a5d9
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4335
3 changed files with 66 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
Tests/LibWeb/Text/input/wpt-import/css/css-box/inheritance.html Normal file
View File

@@ -0,0 +1,35 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>Inheritance of CSS Box Model properties</title>
<link rel="help" href="https://drafts.csswg.org/css-box-3/#property-index">
<link rel="help" href="https://www.w3.org/TR/CSS2/">
<meta name="assert" content="Properties do not inherit.">
<meta name="assert" content="length-percentage properties have initial value 0.">
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script src="../../css/support/inheritance-testcommon.js"></script>
</head>
<body>
<div id="container">
<div id="target"></div>
</div>
<script>
assert_not_inherited('clear', 'none', 'right');
assert_not_inherited('float', 'none', 'right');
assert_not_inherited('margin-bottom', '0px', '10px');
assert_not_inherited('margin-left', '0px', '10px');
assert_not_inherited('margin-right', '0px', '10px');
assert_not_inherited('margin-top', '0px', '10px');
assert_not_inherited('margin-trim', 'none', 'block');
assert_not_inherited('padding-bottom', '0px', '10px');
assert_not_inherited('padding-left', '0px', '10px');
assert_not_inherited('padding-right', '0px', '10px');
assert_not_inherited('padding-top', '0px', '10px');
assert_inherited('visibility', 'visible', 'collapse');
</script>
</body>
</html>