eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Resolve FIXME in media select resource algorithm

Browse Source 
Fixes at least three WPT test that were previously timing out:
- html/semantics/embedded-content/media-elements/error-codes/error.html
- html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc.html
- html/semantics/embedded-content/the-video-element/video_crash_empty_src.html
This commit is contained in:
Prajjwal
2025-06-02 04:26:02 +05:30
committed by Shannon Booth
parent bfc79a403d
commit e1d2582680
Notes: github-actions[bot] 2025-06-16 11:29:21 +00:00 
Author: https://github.com/prajjwal000 🔰
Commit: https://github.com/LadybirdBrowser/ladybird/commit/e1d2582680e
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4956
Reviewed-by: https://github.com/AtkinsSJ
Reviewed-by: https://github.com/shannonbooth ✅
8 changed files with 334 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Tests/LibWeb/Text/expected/wpt-import/html/semantics/embedded-content/media-elements/error-codes/error.txt Normal file
View File

@@ -0,0 +1,12 @@
Harness status: OK
Found 6 tests
4 Pass
2 Fail
Pass audio.error initial value
Fail audio.error after successful load
Pass audio.error after setting src to the empty string
Pass video.error initial value
Fail video.error after successful load
Pass video.error after setting src to the empty string

23
Tests/LibWeb/Text/expected/wpt-import/html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc.txt Normal file
View File

@@ -0,0 +1,23 @@
Harness status: OK
Found 18 tests
18 Pass
Pass audio.currentSrc initial value
Pass audio.currentSrc after setting src attribute ""
Pass audio.currentSrc after adding source element with src attribute ""
Pass audio.currentSrc after setting src attribute "."
Pass audio.currentSrc after adding source element with src attribute "."
Pass audio.currentSrc after setting src attribute " "
Pass audio.currentSrc after adding source element with src attribute " "
Pass audio.currentSrc after setting src attribute "data:,"
Pass audio.currentSrc after adding source element with src attribute "data:,"
Pass video.currentSrc initial value
Pass video.currentSrc after setting src attribute ""
Pass video.currentSrc after adding source element with src attribute ""
Pass video.currentSrc after setting src attribute "."
Pass video.currentSrc after adding source element with src attribute "."
Pass video.currentSrc after setting src attribute " "
Pass video.currentSrc after adding source element with src attribute " "
Pass video.currentSrc after setting src attribute "data:,"
Pass video.currentSrc after adding source element with src attribute "data:,"

7
Tests/LibWeb/Text/expected/wpt-import/html/semantics/embedded-content/the-video-element/video_crash_empty_src.txt Normal file
View File

@@ -0,0 +1,7 @@
Harness status: OK
Found 2 tests
2 Pass
Pass src="about:blank" does not crash.
Pass src="" does not crash.