eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibMedia+LibWeb: Indicate playback states' available data with an enum

Browse Source 
This allows us to differentiate between having no data available yet,
having current data, and having future data. The main purpose of this
is to allow a new starting state to explicitly force HAVE_METADATA
instead of >= HAVE_CURRENT_DATA.

Note that the SeekingStateHandler returns Current instead of None. This
is deliberate, since the buffered ranges from the demuxer(s) can be
used to inform whether the possibly-current data is actually available
at the seek target.
This commit is contained in:
Zaggy1024
2026-04-18 05:23:13 -05:00
committed by Gregory Bertilson
parent bedcccbdb9
commit e1e752cc28
Notes: github-actions[bot] 2026-04-22 00:13:18 +00:00 
Author: https://github.com/Zaggy1024
Commit: https://github.com/LadybirdBrowser/ladybird/commit/e1e752cc28a
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/9004
10 changed files with 37 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View File

@@ -2125,9 +2125,9 @@ void HTMLMediaElement::update_ready_state()
auto current_time = m_playback_manager->current_time();
auto ranges = m_playback_manager->buffered_time_ranges();
auto current_range = ranges.range_at_or_after(current_time);
auto has_future_data = m_playback_manager->has_future_data();
auto available_data = m_playback_manager->available_data();
if (!has_future_data && !current_range.has_value()) {
if (available_data == Media::AvailableData::Current && !current_range.has_value()) {
// 1. Set the HTMLMediaElement's readyState attribute to HAVE_METADATA.
set_ready_state(ReadyState::HaveMetadata);
// 2. Abort these steps.
@@ -2146,7 +2146,7 @@ void HTMLMediaElement::update_ready_state()
// -> If HTMLMediaElement's buffered contains a TimeRanges that includes the current playback position and
// enough data to ensure uninterrupted playback:
if (has_future_data && (playable_duration >= have_enough_data_duration || current_range_end >= duration)) {
if (available_data == Media::AvailableData::Future && (playable_duration >= have_enough_data_duration || current_range_end >= duration)) {
// 1. Set the HTMLMediaElement's readyState attribute to HAVE_ENOUGH_DATA.
set_ready_state(ReadyState::HaveEnoughData);
@@ -2159,7 +2159,7 @@ void HTMLMediaElement::update_ready_state()
// -> If HTMLMediaElement's buffered contains a TimeRanges that includes the current playback position and
// some time beyond the current playback position:
if (has_future_data && playable_duration > AK::Duration::zero()) {
if (available_data == Media::AvailableData::Future && playable_duration > AK::Duration::zero()) {
// 1. Set the HTMLMediaElement's readyState attribute to HAVE_FUTURE_DATA.
set_ready_state(ReadyState::HaveFutureData);