eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Return a GC::Ref from Temporal::get_options_object

Browse Source 
The Object returned here is always non-null.
This commit is contained in:
Timothy Flynn
2024-11-18 10:36:03 -05:00
committed by Tim Flynn
parent c8d2404230
commit e4e05837e1
Notes: github-actions[bot] 2024-11-21 00:06:36 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/e4e05837e18
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2431
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/shannonbooth ✅
7 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp
View File

@@ -13,20 +13,20 @@
namespace JS::Temporal {
// 14.4.1.1 GetOptionsObject ( options ), https://tc39.es/proposal-temporal/#sec-getoptionsobject
ThrowCompletionOr<Object*> get_options_object(VM& vm, Value options)
ThrowCompletionOr<GC::Ref<Object>> get_options_object(VM& vm, Value options)
{
auto& realm = *vm.current_realm();
// 1. If options is undefined, then
if (options.is_undefined()) {
// a. Return OrdinaryObjectCreate(null).
return Object::create(realm, nullptr).ptr();
return Object::create(realm, nullptr);
}
// 2. If options is an Object, then
if (options.is_object()) {
// a. Return options.
return &options.as_object();
return options.as_object();
}
// 3. Throw a TypeError exception.