eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 02:05:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Return a GC::Ref from Temporal::get_options_object

Browse Source 
The Object returned here is always non-null.
This commit is contained in:
Timothy Flynn
2024-11-18 10:36:03 -05:00
committed by Tim Flynn
parent c8d2404230
commit e4e05837e1
Notes: github-actions[bot] 2024-11-21 00:06:36 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/e4e05837e18
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2431
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/shannonbooth ✅
7 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Libraries/LibJS/Runtime/Temporal/AbstractOperations.h
View File

@@ -9,6 +9,7 @@
#pragma once
#include <AK/Variant.h>
#include <LibGC/Ptr.h>
#include <LibJS/Forward.h>
#include <LibJS/Runtime/Completion.h>
#include <LibJS/Runtime/VM.h>
@@ -39,7 +40,7 @@ enum class OptionType {
struct DefaultRequired { };
using OptionDefault = Variant<DefaultRequired, Empty, bool, StringView, double>;
ThrowCompletionOr<Object*> get_options_object(VM&, Value options);
ThrowCompletionOr<GC::Ref<Object>> get_options_object(VM&, Value options);
ThrowCompletionOr<Value> get_option(VM&, Object const& options, PropertyKey const& property, OptionType type, ReadonlySpan<StringView> values, OptionDefault const&);
template<size_t Size>