eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Implement autofocus candidate processing

Browse Source 
This change implements the algorithms necessary to focus elements with
the autofocus attribute on page load.
This commit is contained in:
Tim Ledbetter
2026-04-21 18:17:38 +01:00
committed by Shannon Booth
parent baefb51902
commit e5d615cb11
Notes: github-actions[bot] 2026-04-21 21:48:16 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/e5d615cb11c
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/9016
Reviewed-by: https://github.com/shannonbooth
19 changed files with 345 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Libraries/LibWeb/HTML/EventLoop/EventLoop.cpp
View File

@@ -365,7 +365,12 @@ void EventLoop::update_the_rendering()
// FIXME: 6. For each doc of docs, reveal doc.
// FIXME: 7. For each doc of docs, flush autofocus candidates for doc if its node navigable is a top-level traversable.
// 7. For each doc of docs, flush autofocus candidates for doc if its node navigable is a top-level traversable.
for (auto& document : docs) {
auto navigable = document->navigable();
if (navigable && navigable->is_top_level_traversable())
document->flush_autofocus_candidates();
}
// 8. For each doc of docs, run the resize steps for doc. [CSSOMVIEW]
for (auto& document : docs) {

38
Libraries/LibWeb/HTML/HTMLOrSVGElement.cpp
View File

@@ -9,7 +9,10 @@
#include <LibWeb/HTML/Focus.h>
#include <LibWeb/HTML/HTMLElement.h>
#include <LibWeb/HTML/HTMLOrSVGElement.h>
#include <LibWeb/HTML/Navigable.h>
#include <LibWeb/HTML/PolicyContainers.h>
#include <LibWeb/HTML/SandboxingFlagSet.h>
#include <LibWeb/HTML/TraversableNavigable.h>
#include <LibWeb/MathML/MathMLElement.h>
#include <LibWeb/SVG/SVGElement.h>
@@ -108,6 +111,41 @@ void HTMLOrSVGElement<ElementBase>::inserted()
// 2.3. Set element's [[CryptographicNonce]] to nonce.
m_cryptographic_nonce = nonce;
}
// https://html.spec.whatwg.org/multipage/interaction.html#the-autofocus-attribute
if (element.has_attribute(HTML::AttributeNames::autofocus)) {
// When an element with the autofocus attribute specified is inserted into a document, run the following steps:
// FIXME: 1. If the user has indicated (for example, by starting to type in a form control) that they do not
// wish focus to be changed, then optionally return.
// 2. Let target be the element's node document.
auto& target = element.document();
// 3. If target is not fully active, then return.
if (!target.is_fully_active())
return;
// 4. If target's active sandboxing flag set has the sandboxed automatic features browsing
// context flag, then return.
if (has_flag(target.active_sandboxing_flag_set(), HTML::SandboxingFlagSet::SandboxedAutomaticFeatures))
return;
// 5. If the allow focus steps given target return false, then return.
if (!target.allow_focus())
return;
// 6. Let topDocument be target's node navigable's top-level traversable's active document.
auto top_document = target.navigable()->top_level_traversable()->active_document();
// 7. If topDocument's autofocus processed flag is false, then remove the element from topDocument's autofocus
// candidates, and append the element to topDocument's autofocus candidates.
if (!top_document->autofocus_processed_flag()) {
auto& candidates = top_document->autofocus_candidates();
candidates.remove_first_matching([&element](auto const& other) { return other.ptr() == &element; });
candidates.append(GC::Ref { element });
}
}
}
template<typename ElementBase>