eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-12 01:46:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Extract TextDecoderCommon mixin into its own files

Browse Source 
This mirrors the existing TextEncoderCommon split and lets a future
TextDecoderStream share the same encoding/fatal/ignoreBOM state with
TextDecoder. The state (decoder reference, encoding name, error mode,
ignore-BOM flag, and BOM-seen flag) all moves into a
TextDecoderCommonMixin base class so both interfaces can inherit it.
This commit is contained in:
Andreas Kling
2026-04-28 11:32:35 +02:00
committed by Shannon Booth
parent 57d9668bca
commit e629e6a323
Notes: github-actions[bot] 2026-04-28 17:18:25 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/e629e6a3235
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/9143
Reviewed-by: https://github.com/shannonbooth
8 changed files with 91 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Libraries/LibWeb/Encoding/TextDecoder.cpp
View File

@@ -35,7 +35,7 @@ WebIDL::ExceptionOr<GC::Ref<TextDecoder>> TextDecoder::construct_impl(JS::Realm&
auto lowercase_encoding_name = encoding.value().to_ascii_lowercase_string();
// 4. If options["fatal"] is true, then set this’s error mode to "fatal".
auto fatal = options.value_or({}).fatal;
auto error_mode = options.value_or({}).fatal ? ErrorMode::Fatal : ErrorMode::Replacement;
// 5. Set this’s ignore BOM to options["ignoreBOM"].
auto ignore_bom = options.value_or({}).ignore_bom;
@@ -44,16 +44,13 @@ WebIDL::ExceptionOr<GC::Ref<TextDecoder>> TextDecoder::construct_impl(JS::Realm&
auto decoder = TextCodec::decoder_for_exact_name(encoding.value());
VERIFY(decoder.has_value());
return realm.create<TextDecoder>(realm, *decoder, lowercase_encoding_name, fatal, ignore_bom);
return realm.create<TextDecoder>(realm, *decoder, lowercase_encoding_name, error_mode, ignore_bom);
}
// https://encoding.spec.whatwg.org/#dom-textdecoder
TextDecoder::TextDecoder(JS::Realm& realm, TextCodec::Decoder& decoder, FlyString encoding, bool fatal, bool ignore_bom)
TextDecoder::TextDecoder(JS::Realm& realm, TextCodec::Decoder& decoder, FlyString encoding, ErrorMode error_mode, bool ignore_bom)
: PlatformObject(realm)
, m_decoder(decoder)
, m_encoding(move(encoding))
, m_fatal(fatal)
, m_ignore_bom(ignore_bom)
, TextDecoderCommonMixin(decoder, move(encoding), error_mode, ignore_bom)
{
}