eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Capitalize "No Popover state" consistently

Browse Source 
Corresponds partly to 8035a256bf
This commit is contained in:
Sam Atkins
2025-07-08 10:21:00 +01:00
committed by Tim Ledbetter
parent 31b302fc73
commit e74afec9c5
Notes: github-actions[bot] 2025-07-08 16:11:09 +00:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/LadybirdBrowser/ladybird/commit/e74afec9c5d
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5353
Reviewed-by: https://github.com/tcl3 ✅
4 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Libraries/LibWeb/CSS/SelectorEngine.cpp
View File

@@ -852,7 +852,8 @@ static inline bool matches_pseudo_class(CSS::Selector::SimpleSelector::PseudoCla
}
case CSS::PseudoClass::PopoverOpen: {
// https://html.spec.whatwg.org/multipage/semantics-other.html#selector-popover-open
// The :popover-open pseudo-class is defined to match any HTML element whose popover attribute is not in the no popover state and whose popover visibility state is showing.
// The :popover-open pseudo-class is defined to match any HTML element whose popover attribute is not in the
// No Popover state and whose popover visibility state is showing.
if (is<HTML::HTMLElement>(element) && element.has_attribute(HTML::AttributeNames::popover)) {
auto& html_element = static_cast<HTML::HTMLElement const&>(element);
return html_element.popover_visibility_state() == HTML::HTMLElement::PopoverVisibilityState::Showing;