eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Reserve zero for not supported transfer type

Browse Source 
Previously we were using 0 for both unsupported type and MessagePort,
which led to crashing on attempt to decode unsupported transfer type as
MessagePort.

Fixes crashing on
https://docs.mapbox.com/mapbox-gl-js/clip-layer-building-demo.html
This commit is contained in:
Aliaksandr Kalenik
2025-04-13 19:50:49 +02:00
committed by Alexander Kalenik
parent e18e7d6019
commit ea8a6b43f7
Notes: github-actions[bot] 2025-04-14 15:02:44 +00:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/LadybirdBrowser/ladybird/commit/ea8a6b43f7b
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4342
Reviewed-by: https://github.com/trflynn89
3 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibWeb/HTML/StructuredSerialize.cpp
View File

@@ -1291,9 +1291,11 @@ static bool is_interface_exposed_on_target_realm(TransferType name, JS::Realm& r
case TransferType::MessagePort:
return intrinsics.is_exposed("MessagePort"sv);
break;
default:
case TransferType::Unknown:
dbgln("Unknown interface type for transfer: {}", to_underlying(name));
break;
default:
VERIFY_NOT_REACHED();
}
return false;
}
@@ -1310,6 +1312,8 @@ static WebIDL::ExceptionOr<GC::Ref<Bindings::PlatformObject>> create_transferred
case TransferType::ResizableArrayBuffer:
dbgln("ArrayBuffer ({}) is not a platform object.", to_underlying(name));
break;
case TransferType::Unknown:
break;
}
VERIFY_NOT_REACHED();
}