eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 03:57:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Add missing StyleInvalidationReason for HTMLDialogElement

Browse Source 
We were accidentally using NodeRemove instead of a unique reason.
This commit is contained in:
Andreas Kling
2025-08-18 23:20:20 +02:00
committed by Jelle Raaijmakers
parent 83b1ead1e7
commit ec2b568919
Notes: github-actions[bot] 2025-08-20 07:16:50 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/ec2b5689196
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5917
Reviewed-by: https://github.com/gmta ✅
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLDialogElement.cpp
View File

@@ -467,7 +467,7 @@ void HTMLDialogElement::set_is_modal(bool is_modal)
if (m_is_modal == is_modal)
return;
m_is_modal = is_modal;
invalidate_style(DOM::StyleInvalidationReason::NodeRemove);
invalidate_style(DOM::StyleInvalidationReason::HTMLDialogElementSetIsModal);
}
// https://html.spec.whatwg.org/multipage/interactive-elements.html#the-dialog-element:is-valid-invoker-command-steps