eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-30 19:47:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Support the importing of ml-kem keys in raw-seed format

Browse Source
This commit is contained in:
Tete17
2026-01-04 17:43:50 +01:00
committed by Shannon Booth
parent ab74519a0b
commit ed025f5fcd
Notes: github-actions[bot] 2026-01-06 00:07:52 +00:00 
Author: https://github.com/tete17
Commit: https://github.com/LadybirdBrowser/ladybird/commit/ed025f5fcda
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7320
Reviewed-by: https://github.com/shannonbooth ✅
2 changed files with 74 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
Libraries/LibWeb/Crypto/CryptoAlgorithms.cpp
View File

@@ -9167,7 +9167,54 @@ WebIDL::ExceptionOr<GC::Ref<CryptoKey>> MLKEM::import_key(AlgorithmParams const&
// 6. Set the [[algorithm]] internal slot of key to algorithm.
key->set_algorithm(algorithm);
}
// FIXME: -> If format is "raw-seed":
// -> If format is "raw-seed":
else if (key_format == Bindings::KeyFormat::RawSeed) {
// 1. If usages contains an entry which is not "decapsulateKey" or "decapsulateBits" then throw a SyntaxError.
for (auto const& usage : usages) {
if (usage != Bindings::KeyUsage::Decapsulatekey && usage != Bindings::KeyUsage::Decapsulatebits) {
return WebIDL::SyntaxError::create(m_realm, Utf16String::formatted("Invalid key usage '{}'", idl_enum_to_string(usage)));
}
}
// 2. Let data be keyData.
VERIFY(key_data.has<ByteBuffer>());
auto const data = move(key_data.get<ByteBuffer>());
// 3. If the length in bits of data is not 512 then throw a DataError.
if (data.size() * 8 != 512)
return WebIDL::DataError::create(m_realm, "Invalid key format"_utf16);
// 4. Let privateKey be the result of performing the ML-KEM.KeyGen_internal function described in
// Section 6.1 of [FIPS-203] with the parameter set indicated by the name member of
// normalizedAlgorithm, using the first 256 bits of data as d and the last 256 bits of data as z.
auto maybe_key_pair = [&] {
if (params.name == "ML-KEM-512")
return ::Crypto::PK::MLKEM::generate_key_pair(::Crypto::PK::MLKEMSize::MLKEM512, data);
if (params.name == "ML-KEM-768")
return ::Crypto::PK::MLKEM::generate_key_pair(::Crypto::PK::MLKEMSize::MLKEM768, data);
if (params.name == "ML-KEM-1024")
return ::Crypto::PK::MLKEM::generate_key_pair(::Crypto::PK::MLKEMSize::MLKEM1024, data);
VERIFY_NOT_REACHED();
}();
if (maybe_key_pair.is_error())
return WebIDL::OperationError::create(m_realm, Utf16String::formatted("Key generation failed: {}", maybe_key_pair.release_error()));
auto const key_pair = maybe_key_pair.release_value();
// 5. Let key be a new CryptoKey that represents the ML-KEM private key identified by privateKey.
key = CryptoKey::create(m_realm, key_pair.private_key);
// 6. Set the [[type]] internal slot of key to "private"
key->set_type(Bindings::KeyType::Private);
// 7. Let algorithm be a new KeyAlgorithm.
auto const algorithm = KeyAlgorithm::create(m_realm);
// 8. Set the name attribute of algorithm to the name attribute of normalizedAlgorithm.
algorithm->set_name(params.name);
// 9. Set the [[algorithm]] internal slot of key to algorithm.
key->set_algorithm(algorithm);
}
// FIXME: -> If format is "jwk":
// -> Otherwise:
else {