eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Don't disassociate animations from timeline when target orphaned

Browse Source 
An animation with an orphaned owning element should continue to be
ticked by the timeline.

Reverts c8b574e and instead avoids leaking animations by not visiting
`Animation`s from `AnimationTimeline`s.

Fixes a timeout in the imported test
This commit is contained in:
Callum Law
2025-12-18 13:53:21 +13:00
committed by Alexander Kalenik
parent d62e2e39a3
commit f235625670
Notes: github-actions[bot] 2025-12-23 13:55:58 +00:00 
Author: https://github.com/Calme1709
Commit: https://github.com/LadybirdBrowser/ladybird/commit/f235625670b
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7174
Reviewed-by: https://github.com/kalenikaliaksandr ✅
10 changed files with 156 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibWeb/Animations/Animation.cpp
View File

@@ -1445,4 +1445,10 @@ void Animation::visit_edges(Cell::Visitor& visitor)
m_owning_element->visit(visitor);
}
void Animation::finalize()
{
if (m_timeline)
m_timeline->disassociate_with_animation(*this);
}
}