eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-28 10:37:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Stop worrying about Instruction destructors

Browse Source 
By adding static_asserts to prove that all of our generated instruction
classes are trivially destructible, we can confidently remove the
destructor walk in BasicBlock and save ourselves some unnecessary work.
This commit is contained in:
Andreas Kling
2025-11-21 08:26:37 +01:00
committed by Andreas Kling
parent 370b81f1b7
commit f37063e2a1
Notes: github-actions[bot] 2025-11-21 08:47:34 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/f37063e2a13
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6888
4 changed files with 2 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Libraries/LibJS/Bytecode/BasicBlock.cpp
View File

@@ -21,15 +21,7 @@ BasicBlock::BasicBlock(u32 index, String name)
{
}
BasicBlock::~BasicBlock()
{
Bytecode::InstructionStreamIterator it(instruction_stream());
while (!it.at_end()) {
auto& to_destroy = (*it);
++it;
Instruction::destroy(const_cast<Instruction&>(to_destroy));
}
}
BasicBlock::~BasicBlock() = default;
void BasicBlock::grow(size_t additional_size)
{