eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-30 19:47:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Change PropertyName(Symbol*) => PropertyName(Symbol&)

Browse Source 
Requires a bunch of find-and-replace updates across LibJS, but
constructing a PropertyName from a nullptr Symbol* should not be
possible - let's enforce this at the compiler level instead of using
VERIFY() (and already dereference Symbol pointers at the call site).
This commit is contained in:
Linus Groh
2021-06-25 18:37:14 +01:00
parent 3d5340d033
commit f4867572b7
Notes: sideshowbarker 2024-07-18 11:30:34 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/f4867572b7b
Pull-request: https://github.com/SerenityOS/serenity/pull/8247
Reviewed-by: https://github.com/IdanHo ✅
Reviewed-by: https://github.com/alimpfard ✅
Reviewed-by: https://github.com/awesomekling ✅
40 changed files with 59 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/ArrayBufferConstructor.cpp
View File

@@ -31,7 +31,7 @@ void ArrayBufferConstructor::initialize(GlobalObject& global_object)
define_native_function(vm.names.isView, is_view, 1, attr);
// 25.1.5.4 ArrayBuffer.prototype [ @@toStringTag ], https://tc39.es/ecma262/#sec-arraybuffer.prototype-@@tostringtag
define_native_accessor(vm.well_known_symbol_species(), symbol_species_getter, {}, Attribute::Configurable);
define_native_accessor(*vm.well_known_symbol_species(), symbol_species_getter, {}, Attribute::Configurable);
}
ArrayBufferConstructor::~ArrayBufferConstructor()