eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 10:07:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Remove some irrelevant hash lookups in ESFO constructor

Browse Source 
If we don't have parameter expressions, we don't need to collect
metadata about whether instantiated var names collide with parameter
names or function names, as these flags are only used in the parameter
code path.
This commit is contained in:
Andreas Kling
2025-03-27 17:07:40 +00:00
committed by Andreas Kling
parent c037bda455
commit f5dd776b11
Notes: github-actions[bot] 2025-03-27 23:13:02 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/f5dd776b110
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4128
Reviewed-by: https://github.com/Hendiadyoin1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp
View File

@@ -250,8 +250,8 @@ ECMAScriptFunctionObject::ECMAScriptFunctionObject(FlyString name, ByteString so
// 3. Perform ! env.InitializeBinding(n, undefined).
m_var_names_to_initialize_binding.append({
.identifier = id,
.parameter_binding = parameter_bindings.contains(id.string()),
.function_name = function_names.contains(id.string()),
// NOTE: We don't have to set parameter_binding or function_name here
// since those are only relevant in the hasParameterExpressions==true path.
});
if (!id.is_local())