eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Parse @counter-style system descriptor

Browse Source
This commit is contained in:
Callum Law
2026-01-31 21:09:11 +13:00
committed by Sam Atkins
parent 703259a24c
commit f60bfd9e9e
Notes: github-actions[bot] 2026-02-06 10:38:11 +00:00 
Author: https://github.com/Calme1709
Commit: https://github.com/LadybirdBrowser/ladybird/commit/f60bfd9e9e2
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7708
Reviewed-by: https://github.com/AtkinsSJ ✅
17 changed files with 270 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
Libraries/LibWeb/CSS/Parser/DescriptorParsing.cpp
View File

@@ -6,6 +6,7 @@
#include <LibWeb/CSS/Parser/ErrorReporter.h>
#include <LibWeb/CSS/Parser/Parser.h>
#include <LibWeb/CSS/StyleValues/CounterStyleSystemStyleValue.h>
#include <LibWeb/CSS/StyleValues/FontSourceStyleValue.h>
#include <LibWeb/CSS/StyleValues/KeywordStyleValue.h>
#include <LibWeb/CSS/StyleValues/LengthStyleValue.h>
@@ -60,6 +61,34 @@ Parser::ParseErrorOr<NonnullRefPtr<StyleValue const>> Parser::parse_descriptor_v
},
[&](DescriptorMetadata::ValueType value_type) -> RefPtr<StyleValue const> {
switch (value_type) {
case DescriptorMetadata::ValueType::CounterStyleSystem: {
// https://drafts.csswg.org/css-counter-styles-3/#counter-style-system
// cyclic | numeric | alphabetic | symbolic | additive | [fixed <integer>?] | [ extends <counter-style-name> ]
auto keyword_value = parse_keyword_value(tokens);
if (!keyword_value)
return nullptr;
if (auto system = keyword_to_counter_style_system(keyword_value->to_keyword()); system.has_value())
return CounterStyleSystemStyleValue::create(system.release_value());
if (keyword_value->to_keyword() == Keyword::Fixed) {
auto integer_value = parse_integer_value(tokens);
return CounterStyleSystemStyleValue::create_fixed(integer_value);
}
if (keyword_value->to_keyword() == Keyword::Extends) {
auto counter_style_name = parse_counter_style_name(tokens);
if (!counter_style_name.has_value())
return nullptr;
return CounterStyleSystemStyleValue::create_extends(counter_style_name.release_value());
}
return nullptr;
}
case DescriptorMetadata::ValueType::CropOrCross: {
// crop || cross
auto first = parse_keyword_value(tokens);