eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 09:45:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Don't strip leading '?' in query initializing a URL

Browse Source 
In our implementation of url-initialize, we were invoking the
constructor of URLSearchParams:

https://url.spec.whatwg.org/#dom-urlsearchparams-urlsearchparams

Instead of the 'initialize' AO:

https://url.spec.whatwg.org/#urlsearchparams-initialize

This has the small difference of stripping any leading '?' from the
query (which we are not meant to be doing!).
This commit is contained in:
Shannon Booth
2024-08-06 23:27:11 +12:00
committed by Tim Ledbetter
parent d7b19b3278
commit fd4e943e12
Notes: github-actions[bot] 2024-08-06 22:09:12 +00:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/LadybirdBrowser/ladybird/commit/fd4e943e12a
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/987
Reviewed-by: https://github.com/tcl3 ✅
5 changed files with 34 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Tests/LibWeb/Text/input/URL/url.html
View File

@@ -36,6 +36,7 @@
{ input: ' \t', base: 'http://ladybird.org/foo/bar' },
{ input: '/c:/foo/bar', base: 'file:///c:/baz/qux' },
{ input: '', base: 'file:///test?test#test' },
{ input: '??a=b&c=d', base: 'http://example.org/foo/bar' },
];
for (url of urls) {