eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 10:07:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Decouple new_function_environment() from FunctionObject

Browse Source 
Now that only ECMAScriptFunctionObject uses this, we can remove the
FunctionObject::new_function_environment() pure virtual method and just
implement it as a standalone AO with an ECMAScriptFunctionObject
parameter, next to the other NewFooEnvironment AOs.
This commit is contained in:
Linus Groh
2021-10-08 21:24:51 +01:00
parent 53af66d57d
commit fe5c2b7bb9
Notes: sideshowbarker 2024-07-18 02:53:07 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/fe5c2b7bb99
Pull-request: https://github.com/SerenityOS/serenity/pull/10402
Reviewed-by: https://github.com/awesomekling ✅
11 changed files with 30 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.h
View File

@@ -79,7 +79,6 @@ protected:
private:
virtual bool is_ecmascript_function_object() const override { return true; }
virtual FunctionEnvironment* new_function_environment(Object* new_target) override;
virtual void visit_edges(Visitor&) override;
void prepare_for_ordinary_call(ExecutionContext& callee_context, Object* new_target);