mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-05-12 01:46:46 +02:00
245b7d74a7
Move weak container cleanup (remove_dead_cells) out of both sweep_dead_cells() and start_incremental_sweep() to the place where it is actually safe to inspect cell state: collect_garbage(). Previously, remove_dead_cells could access cells that had already been swept and poisoned by ASAN, causing use-after-poison crashes when a new GC triggered while an incremental sweep was in progress.
60 lines
1.7 KiB
C++
60 lines
1.7 KiB
C++
/*
|
|
* Copyright (c) 2021-2022, Idan Horowitz <idan.horowitz@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/SinglyLinkedList.h>
|
|
#include <LibGC/Ptr.h>
|
|
#include <LibGC/WeakContainer.h>
|
|
#include <LibJS/Export.h>
|
|
#include <LibJS/Runtime/FunctionObject.h>
|
|
#include <LibJS/Runtime/GlobalObject.h>
|
|
#include <LibJS/Runtime/JobCallback.h>
|
|
#include <LibJS/Runtime/Object.h>
|
|
#include <LibJS/Runtime/Value.h>
|
|
|
|
namespace JS {
|
|
|
|
class JS_API FinalizationRegistry final
|
|
: public Object
|
|
, public GC::WeakContainer {
|
|
JS_OBJECT(FinalizationRegistry, Object);
|
|
GC_DECLARE_ALLOCATOR(FinalizationRegistry);
|
|
|
|
public:
|
|
virtual ~FinalizationRegistry() override = default;
|
|
|
|
void add_finalization_record(Cell& target, Value held_value, Cell* unregister_token);
|
|
bool remove_by_token(Cell& unregister_token);
|
|
ThrowCompletionOr<void> cleanup(GC::Ptr<JobCallback> = {});
|
|
|
|
virtual Cell const& owner_cell(Badge<GC::Heap>) const override { return *this; }
|
|
virtual void remove_dead_cells(Badge<GC::Heap>) override;
|
|
|
|
Realm& realm() { return *m_realm; }
|
|
Realm const& realm() const { return *m_realm; }
|
|
|
|
JobCallback& cleanup_callback() { return *m_cleanup_callback; }
|
|
JobCallback const& cleanup_callback() const { return *m_cleanup_callback; }
|
|
|
|
private:
|
|
FinalizationRegistry(Realm&, GC::Ref<JobCallback>, Object& prototype);
|
|
|
|
virtual void visit_edges(Visitor& visitor) override;
|
|
|
|
GC::Ref<Realm> m_realm;
|
|
GC::Ref<JobCallback> m_cleanup_callback;
|
|
|
|
struct FinalizationRecord {
|
|
GC::Ptr<Cell> target;
|
|
Value held_value;
|
|
GC::Ptr<Cell> unregister_token;
|
|
};
|
|
SinglyLinkedList<FinalizationRecord> m_records;
|
|
};
|
|
|
|
}
|