mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-05-12 01:46:46 +02:00
245b7d74a7
Move weak container cleanup (remove_dead_cells) out of both sweep_dead_cells() and start_incremental_sweep() to the place where it is actually safe to inspect cell state: collect_garbage(). Previously, remove_dead_cells could access cells that had already been swept and poisoned by ASAN, causing use-after-poison crashes when a new GC triggered while an incremental sweep was in progress.
53 lines
1.4 KiB
C++
53 lines
1.4 KiB
C++
/*
|
|
* Copyright (c) 2021, Idan Horowitz <idan.horowitz@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/HashMap.h>
|
|
#include <LibGC/WeakContainer.h>
|
|
#include <LibJS/Export.h>
|
|
#include <LibJS/Runtime/GlobalObject.h>
|
|
#include <LibJS/Runtime/Object.h>
|
|
|
|
namespace JS {
|
|
|
|
class JS_API WeakMap final
|
|
: public Object
|
|
, public GC::WeakContainer {
|
|
JS_OBJECT(WeakMap, Object);
|
|
GC_DECLARE_ALLOCATOR(WeakMap);
|
|
|
|
public:
|
|
static GC::Ref<WeakMap> create(Realm&);
|
|
|
|
virtual ~WeakMap() override = default;
|
|
|
|
Optional<Value> weak_map_get(GC::Ptr<Cell>) const;
|
|
bool weak_map_has(GC::Ptr<Cell>) const;
|
|
void weak_map_set(GC::Ptr<Cell>, Value);
|
|
bool weak_map_remove(GC::Ptr<Cell>);
|
|
size_t weak_map_size() const { return m_values.size(); }
|
|
|
|
virtual Cell const& owner_cell(Badge<GC::Heap>) const override { return *this; }
|
|
virtual void remove_dead_cells(Badge<GC::Heap>) override;
|
|
virtual size_t external_memory_size() const override;
|
|
|
|
private:
|
|
explicit WeakMap(Object& prototype);
|
|
|
|
virtual bool is_weak_map() const final { return true; }
|
|
void visit_edges(Visitor&) override;
|
|
|
|
void account_external_memory_change(size_t old_external_memory_size);
|
|
|
|
HashMap<GC::Ptr<Cell>, Value> m_values; // This stores Cell pointers instead of Object pointers to aide with sweeping
|
|
};
|
|
|
|
template<>
|
|
inline bool Object::fast_is<WeakMap>() const { return is_weak_map(); }
|
|
|
|
}
|