mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-05-12 09:56:45 +02:00
d1fc4b4234
Previously, presentational hints bypassed the regular cascade pipeline and wrote directly into `CascadedProperties` under `CascadeOrigin::Author`. That meant `var()` substitution and the invalid-at-computed-value-time fallback had to be duplicated in a separate per-element pass, which in practice missed the IACVT step and could leave a `GuaranteedInvalidStyleValue` in the cascaded properties. This caused a crash in downstream code that assumed the value had been resolved. This introduces an `AuthorPresentationalHint` cascade origin and feeds them through the cascade as normal declarations. This means that `var()` resolution now happens in only one place.
61 lines
2.0 KiB
C++
61 lines
2.0 KiB
C++
/*
|
|
* Copyright (c) 2020, the SerenityOS developers.
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/GenericShorthands.h>
|
|
#include <LibWeb/HTML/HTMLElement.h>
|
|
#include <LibWeb/HTML/HTMLOListElement.h>
|
|
#include <LibWeb/HTML/HTMLUListElement.h>
|
|
#include <LibWeb/WebIDL/Types.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
class HTMLLIElement final : public HTMLElement {
|
|
WEB_PLATFORM_OBJECT(HTMLLIElement, HTMLElement);
|
|
GC_DECLARE_ALLOCATOR(HTMLLIElement);
|
|
|
|
public:
|
|
virtual ~HTMLLIElement() override;
|
|
|
|
// https://www.w3.org/TR/html-aria/#el-li
|
|
virtual Optional<ARIA::Role> default_role() const override
|
|
{
|
|
for (auto ancestor = parent_element(); ancestor; ancestor = ancestor->parent_element()) {
|
|
if (ancestor->role_or_default() == ARIA::Role::list)
|
|
return ARIA::Role::listitem;
|
|
}
|
|
// https://w3c.github.io/core-aam/#roleMappingComputedRole
|
|
// When an element has a role but is not contained in the required context (for example, an orphaned listitem
|
|
// without the required accessible parent of role list), User Agents MUST ignore the role token, and return the
|
|
// computedrole as if the ignored role token had not been included.
|
|
return ARIA::Role::none;
|
|
}
|
|
|
|
WebIDL::Long value();
|
|
void set_value(WebIDL::Long value);
|
|
|
|
virtual bool is_html_li_element() const override { return true; }
|
|
|
|
private:
|
|
HTMLLIElement(DOM::Document&, DOM::QualifiedName);
|
|
|
|
virtual void initialize(JS::Realm&) override;
|
|
virtual void attribute_changed(FlyString const& local_name, Optional<String> const& old_value, Optional<String> const& value, Optional<FlyString> const& namespace_) override;
|
|
|
|
virtual bool is_presentational_hint(FlyString const&) const override;
|
|
virtual void apply_presentational_hints(Vector<CSS::StyleProperty>&) const override;
|
|
};
|
|
|
|
}
|
|
|
|
namespace Web::DOM {
|
|
|
|
template<>
|
|
inline bool Node::fast_is<Web::HTML::HTMLLIElement>() const { return is_html_li_element(); }
|
|
|
|
}
|