mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-05-11 17:37:33 +02:00
d1fc4b4234
Previously, presentational hints bypassed the regular cascade pipeline and wrote directly into `CascadedProperties` under `CascadeOrigin::Author`. That meant `var()` substitution and the invalid-at-computed-value-time fallback had to be duplicated in a separate per-element pass, which in practice missed the IACVT step and could leave a `GuaranteedInvalidStyleValue` in the cascaded properties. This caused a crash in downstream code that assumed the value had been resolved. This introduces an `AuthorPresentationalHint` cascade origin and feeds them through the cascade as normal declarations. This means that `var()` resolution now happens in only one place.
75 lines
2.5 KiB
C++
75 lines
2.5 KiB
C++
/*
|
|
* Copyright (c) 2020, the SerenityOS developers.
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/Bindings/HTMLTableColElement.h>
|
|
#include <LibWeb/Bindings/Intrinsics.h>
|
|
#include <LibWeb/CSS/ComputedProperties.h>
|
|
#include <LibWeb/HTML/HTMLTableColElement.h>
|
|
#include <LibWeb/HTML/Numbers.h>
|
|
#include <LibWeb/HTML/Parser/HTMLParser.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
GC_DEFINE_ALLOCATOR(HTMLTableColElement);
|
|
|
|
HTMLTableColElement::HTMLTableColElement(DOM::Document& document, DOM::QualifiedName qualified_name)
|
|
: HTMLElement(document, move(qualified_name))
|
|
{
|
|
}
|
|
|
|
HTMLTableColElement::~HTMLTableColElement() = default;
|
|
|
|
void HTMLTableColElement::initialize(JS::Realm& realm)
|
|
{
|
|
WEB_SET_PROTOTYPE_FOR_INTERFACE(HTMLTableColElement);
|
|
Base::initialize(realm);
|
|
}
|
|
|
|
// https://html.spec.whatwg.org/multipage/tables.html#dom-colgroup-span
|
|
WebIDL::UnsignedLong HTMLTableColElement::span() const
|
|
{
|
|
// The span IDL attribute must reflect the content attribute of the same name. It is clamped to the range [1, 1000], and its default value is 1.
|
|
if (auto span_string = get_attribute(HTML::AttributeNames::span); span_string.has_value()) {
|
|
if (auto span_digits = parse_non_negative_integer_digits(*span_string); span_digits.has_value()) {
|
|
auto span = span_digits->to_number<i64>();
|
|
// NOTE: If span has no value at this point, the value must be larger than NumericLimits<i64>::max(), so return the maximum value of 1000.
|
|
if (!span.has_value())
|
|
return 1000;
|
|
return clamp(*span, 1, 1000);
|
|
}
|
|
}
|
|
return 1;
|
|
}
|
|
|
|
void HTMLTableColElement::set_span(unsigned int value)
|
|
{
|
|
if (value > 2147483647)
|
|
value = 1;
|
|
set_attribute_value(HTML::AttributeNames::span, String::number(value));
|
|
}
|
|
|
|
bool HTMLTableColElement::is_presentational_hint(FlyString const& name) const
|
|
{
|
|
if (Base::is_presentational_hint(name))
|
|
return true;
|
|
|
|
return name == HTML::AttributeNames::width;
|
|
}
|
|
|
|
void HTMLTableColElement::apply_presentational_hints(Vector<CSS::StyleProperty>& properties) const
|
|
{
|
|
Base::apply_presentational_hints(properties);
|
|
for_each_attribute([&](auto& name, auto& value) {
|
|
// https://html.spec.whatwg.org/multipage/rendering.html#tables-2:maps-to-the-dimension-property-2
|
|
if (name == HTML::AttributeNames::width) {
|
|
if (auto parsed_value = parse_dimension_value(value))
|
|
properties.append({ .property_id = CSS::PropertyID::Width, .value = *parsed_value });
|
|
}
|
|
});
|
|
}
|
|
|
|
}
|