mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-05-12 01:46:46 +02:00
568b7ce7ea
The Paintable tree and its supplemental painting data structures were GC allocated because that was the easiest way to manage it and avoid leaks introduced by ref cycles. This included the Paintable subclasses themselves plus StackingContext, ChromeWidget, Scrollbar, ResizeHandle, and scroll-frame state. We are now trying to reduce GC allocation churn on layout and painting updates, so keeping this short-lived rendering tree outside the JS heap is a better fit. Move Paintable to RefCountedTreeNode, make painting helpers ref-counted or weakly reference Paintables, and update the layout and event-handler call sites to use RefPtr/WeakPtr ownership.
35 lines
967 B
C++
35 lines
967 B
C++
/*
|
|
* Copyright (c) 2023, Tim Flynn <trflynn89@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibWeb/Forward.h>
|
|
#include <LibWeb/HTML/BrowsingContext.h>
|
|
#include <LibWeb/Layout/ReplacedBox.h>
|
|
|
|
namespace Web::Layout {
|
|
|
|
class AudioBox final : public ReplacedBox {
|
|
GC_CELL(AudioBox, ReplacedBox);
|
|
GC_DECLARE_ALLOCATOR(AudioBox);
|
|
|
|
public:
|
|
HTML::HTMLAudioElement& dom_node();
|
|
HTML::HTMLAudioElement const& dom_node() const;
|
|
|
|
virtual bool can_have_children() const override;
|
|
|
|
virtual RefPtr<Painting::Paintable> create_paintable() const override;
|
|
|
|
private:
|
|
// Treat the audio element as if it was not a replaced element, sizing based on its content.
|
|
// Thus, it can fit to the shadow DOM controls, instead of having a hardcoded height.
|
|
virtual bool has_auto_content_box_size() const override { return false; }
|
|
AudioBox(DOM::Document&, DOM::Element&, GC::Ref<CSS::ComputedProperties>);
|
|
};
|
|
|
|
}
|