Files
ladybird/Libraries/LibWeb/Layout/Box.cpp
Aliaksandr Kalenik 568b7ce7ea LibWeb: Make Paintable tree ref-counted
The Paintable tree and its supplemental painting data structures were
GC allocated because that was the easiest way to manage it and avoid
leaks introduced by ref cycles. This included the Paintable subclasses
themselves plus StackingContext, ChromeWidget, Scrollbar, ResizeHandle,
and scroll-frame state.

We are now trying to reduce GC allocation churn on layout and painting
updates, so keeping this short-lived rendering tree outside the JS heap
is a better fit. Move Paintable to RefCountedTreeNode, make painting
helpers ref-counted or weakly reference Paintables, and update the
layout and event-handler call sites to use RefPtr/WeakPtr ownership.
2026-05-07 15:03:44 +02:00

96 lines
2.7 KiB
C++

/*
* Copyright (c) 2018-2020, Andreas Kling <andreas@ladybird.org>
* Copyright (c) 2021-2022, Sam Atkins <atkinssj@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibWeb/DOM/Document.h>
#include <LibWeb/HTML/HTMLHtmlElement.h>
#include <LibWeb/Layout/BlockContainer.h>
#include <LibWeb/Layout/Box.h>
#include <LibWeb/Layout/FormattingContext.h>
#include <LibWeb/Layout/TableWrapper.h>
#include <LibWeb/Painting/PaintableBox.h>
namespace Web::Layout {
GC_DEFINE_ALLOCATOR(Box);
Box::Box(DOM::Document& document, DOM::Node* node, GC::Ref<CSS::ComputedProperties> style)
: NodeWithStyleAndBoxModelMetrics(document, node, move(style))
{
}
Box::Box(DOM::Document& document, DOM::Node* node, NonnullOwnPtr<CSS::ComputedValues> computed_values)
: NodeWithStyleAndBoxModelMetrics(document, node, move(computed_values))
{
}
Box::~Box()
{
}
CSS::SizeWithAspectRatio Box::auto_content_box_size() const
{
// https://drafts.csswg.org/css-contain-2/#containment-size
// Replaced elements must be treated as having a natural width and height of 0 and no natural aspect
// ratio.
if (has_size_containment())
return { 0, 0, {} };
return compute_auto_content_box_size();
}
void Box::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_contained_abspos_children);
}
RefPtr<Painting::Paintable> Box::create_paintable() const
{
return Painting::PaintableBox::create(*this);
}
RefPtr<Painting::PaintableBox> Box::paintable_box()
{
if (auto paintable = Node::first_paintable())
return static_cast<Painting::PaintableBox&>(*paintable);
return nullptr;
}
RefPtr<Painting::PaintableBox const> Box::paintable_box() const
{
if (auto paintable = Node::first_paintable())
return static_cast<Painting::PaintableBox const&>(*paintable);
return nullptr;
}
Optional<CSSPixelFraction> Box::preferred_aspect_ratio() const
{
auto const& computed_aspect_ratio = computed_values().aspect_ratio();
// https://www.w3.org/TR/css-contain-2/#containment-size
if (!has_size_containment() && computed_aspect_ratio.use_natural_aspect_ratio_if_available) {
if (auto auto_size = auto_content_box_size(); auto_size.has_aspect_ratio())
return auto_size.aspect_ratio;
}
if (!computed_aspect_ratio.preferred_ratio.has_value())
return {};
auto ratio = computed_aspect_ratio.preferred_ratio.value();
if (ratio.is_degenerate())
return {};
auto fraction = CSSPixelFraction(ratio.numerator(), ratio.denominator());
// ratio.is_degenerate() operates on doubles while CSSPixelFraction uses CSSPixels, so we need to check again here.
if (fraction == 0)
return {};
return fraction;
}
}