mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-05-11 17:37:33 +02:00
568b7ce7ea
The Paintable tree and its supplemental painting data structures were GC allocated because that was the easiest way to manage it and avoid leaks introduced by ref cycles. This included the Paintable subclasses themselves plus StackingContext, ChromeWidget, Scrollbar, ResizeHandle, and scroll-frame state. We are now trying to reduce GC allocation churn on layout and painting updates, so keeping this short-lived rendering tree outside the JS heap is a better fit. Move Paintable to RefCountedTreeNode, make painting helpers ref-counted or weakly reference Paintables, and update the layout and event-handler call sites to use RefPtr/WeakPtr ownership.
41 lines
1.1 KiB
C++
41 lines
1.1 KiB
C++
/*
|
|
* Copyright (c) 2024, Kostya Farber <kostya.farber@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibWeb/DOM/Element.h>
|
|
#include <LibWeb/Forward.h>
|
|
#include <LibWeb/Layout/BlockContainer.h>
|
|
#include <LibWeb/Layout/LegendBox.h>
|
|
#include <LibWeb/Painting/FieldSetPaintable.h>
|
|
namespace Web::Layout {
|
|
|
|
class FieldSetBox final : public BlockContainer {
|
|
GC_CELL(FieldSetBox, BlockContainer);
|
|
GC_DECLARE_ALLOCATOR(FieldSetBox);
|
|
|
|
public:
|
|
FieldSetBox(DOM::Document&, DOM::Element&, GC::Ref<CSS::ComputedProperties>);
|
|
virtual ~FieldSetBox() override;
|
|
|
|
DOM::Element& dom_node() { return static_cast<DOM::Element&>(*BlockContainer::dom_node()); }
|
|
DOM::Element const& dom_node() const { return static_cast<DOM::Element const&>(*BlockContainer::dom_node()); }
|
|
|
|
GC::Ptr<LegendBox const> rendered_legend() const;
|
|
virtual RefPtr<Painting::Paintable> create_paintable() const override;
|
|
|
|
private:
|
|
virtual bool is_fieldset_box() const final
|
|
{
|
|
return true;
|
|
}
|
|
};
|
|
|
|
template<>
|
|
inline bool Node::fast_is<FieldSetBox>() const { return is_fieldset_box(); }
|
|
|
|
}
|