mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-05-11 17:37:33 +02:00
568b7ce7ea
The Paintable tree and its supplemental painting data structures were GC allocated because that was the easiest way to manage it and avoid leaks introduced by ref cycles. This included the Paintable subclasses themselves plus StackingContext, ChromeWidget, Scrollbar, ResizeHandle, and scroll-frame state. We are now trying to reduce GC allocation churn on layout and painting updates, so keeping this short-lived rendering tree outside the JS heap is a better fit. Move Paintable to RefCountedTreeNode, make painting helpers ref-counted or weakly reference Paintables, and update the layout and event-handler call sites to use RefPtr/WeakPtr ownership.
41 lines
1.0 KiB
C++
41 lines
1.0 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <andreas@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibWeb/HTML/HTMLImageElement.h>
|
|
#include <LibWeb/Layout/ReplacedBox.h>
|
|
|
|
namespace Web::Layout {
|
|
|
|
class ImageBox final : public ReplacedBox {
|
|
GC_CELL(ImageBox, ReplacedBox);
|
|
GC_DECLARE_ALLOCATOR(ImageBox);
|
|
|
|
public:
|
|
ImageBox(DOM::Document&, GC::Ptr<DOM::Element>, GC::Ref<CSS::ComputedProperties>, ImageProvider const&);
|
|
virtual ~ImageBox() override;
|
|
|
|
bool renders_as_alt_text() const;
|
|
|
|
virtual RefPtr<Painting::Paintable> create_paintable() const override;
|
|
|
|
auto const& image_provider() const { return m_image_provider; }
|
|
auto& image_provider() { return m_image_provider; }
|
|
|
|
void dom_node_did_update_alt_text(Badge<ImageProvider>);
|
|
|
|
private:
|
|
virtual void visit_edges(Visitor&) override;
|
|
virtual CSS::SizeWithAspectRatio natural_size() const override;
|
|
|
|
ImageProvider const& m_image_provider;
|
|
|
|
mutable Optional<CSSPixels> m_cached_alt_text_width;
|
|
};
|
|
|
|
}
|